Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restart_repro variant to access-om2 (default true) #79

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add restart_repro variant to access-om2 (default true) #79

merged 2 commits into from
Mar 21, 2024

Conversation

aidanheerdegen
Copy link
Member

Add +restart_repro variant to access-om2 (default true)

As the variant only needs to be propagated to mom5 it doesn't add a heap of ugly combinatorial boilerplate.

Closes #78

@CodeGat CodeGat self-requested a review March 21, 2024 01:01
CodeGat
CodeGat approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the line length checks are being ignored anyway (see #73) so they won't hold up merging.
Package additions seem to be logical, so I'm happy to approve.

@aidanheerdegen aidanheerdegen merged commit b08bebd into main Mar 21, 2024
1 check failed
aidanheerdegen added a commit that referenced this pull request Mar 21, 2024
@aidanheerdegen
Revert "Add restart_repro variant to access-om2 (default true) (#79)"
48d272b 
This reverts commit b08bebd.
@aidanheerdegen aidanheerdegen mentioned this pull request Mar 21, 2024
Closed
@harshula
Copy link
Collaborator

We decided to do #83 instead.

@aidanheerdegen
Copy link
Member Author

This was nuked off main with a force push within a few hours of being merged. It seemed cleaner than a revert as it had not had a chance to be used by anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeGat CodeGat CodeGat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mom5 restart_repro variant the default for access-om2
3 participants
@aidanheerdegen @harshula @CodeGat