Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcom4 package #69

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Add gcom4 package #69

merged 7 commits into from
Mar 27, 2024

Conversation

penguian
Copy link
Contributor

Closes Issue #68 . See that issue for a description of the change requested.

This package applies patches to files in https://github.com/ACCESS-NRI/GCOM/tree/dev/Share/gcom4.5_access_config
as per https://github.com/coecms/access-esm-build-gadi/blob/master/Makefile rather than relying on updating the upstream repository.

The package has been tested to the point where the install completes.

@penguian penguian linked an issue Feb 27, 2024 that may be closed by this pull request
@penguian penguian self-assigned this Feb 27, 2024
@penguian penguian marked this pull request as draft February 28, 2024 01:08
@penguian
Copy link
Contributor Author

I could add the following to package.py but have chosen not to at the moment:

  1. Ensure that the dependent fcm executable is at the head of $PATH :
    def setup_build_environment(self, env):
        env.prepend_path("PATH", self.spec["fcm"].prefix.bin)
  1. Alternatively, use the fcm executable defined by join_path(spec["fcm"].prefix.bin, "fcm")):
    def install(self, spec, prefix):

        def make_executable(spec, name):
            return Executable(join_path(spec[name].prefix.bin, name))

        fcm = make_executable(spec, "fcm")
        ...

But I would rather submit the package as-is, and debate the merits of such changes later.

Also, I would like to set the default compiler to "%intel" but I understand that this is not necessary.

@penguian penguian marked this pull request as ready for review February 28, 2024 03:06
packages/gcom4/package.py Outdated Show resolved Hide resolved
packages/gcom4/package.py Outdated Show resolved Hide resolved
@harshula
Copy link
Collaborator

Hi @penguian , Are there more changes planned for the patch() function?

@penguian
Copy link
Contributor Author

@harshula I have made my changes and the PR is again ready for review.

@penguian penguian marked this pull request as draft March 15, 2024 03:20
@penguian penguian marked this pull request as ready for review March 15, 2024 03:20
@penguian penguian merged commit f9d2232 into main Mar 27, 2024
1 check passed
@penguian penguian deleted the 68-spack-package-for-gcom-45 branch March 27, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Spack package for GCOM 4.5
2 participants