Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaccessom2: force CMake to use MPI compiler wrappers #66

Merged
merged 1 commit into from
Feb 21, 2024
Merged

libaccessom2: force CMake to use MPI compiler wrappers #66

merged 1 commit into from
Feb 21, 2024

Conversation

harshula
Copy link
Collaborator

@harshula harshula commented Feb 20, 2024 •
edited
Loading

Details can be found in #61 .

@harshula harshula self-assigned this Feb 20, 2024
@harshula
Copy link
Collaborator Author

Successful compilation test on Gadi of ACCESS-OM2 with the following change to spack-config:

--- a/common/gadi/packages.yaml
+++ b/common/gadi/packages.yaml
@@ -2,7 +2,7 @@ packages:
   all:
     providers:
       # Completely ignoring higher-level configuration options is supported with the :: notation for keys ...
-      mpi:: [nci-openmpi, openmpi]
+      mpi:: [openmpi]
   perl:
     externals:
     - spec: [email protected]~cpanm+shared+threads
@@ -13,9 +13,9 @@ packages:
     - spec: [email protected]
       prefix: /apps/cmake/3.24.2
     buildable: false
-  nci-openmpi:
+  openmpi:
     externals:
-    - spec: [email protected]
+    - spec: [email protected]
       prefix: /apps/openmpi/4.0.2
       modules:
       - openmpi/4.0.2

@harshula
libaccessom2: explicitly set CMake compiler variables
e8ec3cf 
* Thanks to Micael Oliveira for this suggestion.
@harshula harshula force-pushed the 61-deprecate-using-nci-openmpi branch from 183ab51 to e8ec3cf Compare February 20, 2024 23:42
aidanheerdegen
aidanheerdegen approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Worth stating explicitly that this change forces CMake to use the MPI compiler wrappers which add localised flags to find libraries and includes.

@harshula harshula merged commit b72ae78 into main Feb 21, 2024
1 check failed
@harshula harshula deleted the 61-deprecate-using-nci-openmpi branch February 21, 2024 01:09
@harshula harshula changed the title libaccessom2: explicitly set CMake compiler variables libaccessom2: force CMake to use MPI compiler wrappers Feb 21, 2024
harshula added a commit to ACCESS-NRI/spack-config that referenced this pull request Feb 21, 2024
@harshula
common/gadi/packages.yaml: use system openmpi directly
97f7d4d 
* This commit requires ACCESS-NRI/spack-packages#66
  for ACCESS-OM2 to build on Gadi.
@harshula harshula mentioned this pull request Feb 21, 2024
Merged
harshula added a commit to ACCESS-NRI/ACCESS-OM2 that referenced this pull request Feb 21, 2024
@harshula
Depend on openmpi instead of nci-openmpi
644da04 
* Requires: ACCESS-NRI/spack-packages#66
* Requires: ACCESS-NRI/spack-config#26
harshula added a commit to ACCESS-NRI/spack-config that referenced this pull request Feb 21, 2024
@harshula
common/gadi/packages.yaml: use system openmpi directly (#26)
6131f7e 
* This commit requires ACCESS-NRI/spack-packages#66
  for ACCESS-OM2 to build on Gadi.
@harshula harshula mentioned this pull request Feb 21, 2024
Merged
harshula added a commit to ACCESS-NRI/ACCESS-OM2 that referenced this pull request Mar 19, 2024
@harshula
Depend on openmpi instead of nci-openmpi
2ef105b 
* Requires: ACCESS-NRI/spack-packages#66
* Requires: ACCESS-NRI/spack-config#26
aidanheerdegen pushed a commit to ACCESS-NRI/ACCESS-OM2 that referenced this pull request Mar 27, 2024
@harshula @github-actions @CodeGat
Depend on openmpi instead of nci-openmpi and add restart reproducibil…
bf1f97c 
…ity (#49)

* Depend on openmpi instead of nci-openmpi
* versions.json: Updated spack-config to 2024.03.22 (uses system openmpi directly instead of nci-openmpi)
Requires: ACCESS-NRI/spack-packages#66
Requires: ACCESS-NRI/spack-config#26

* spack.yaml: Updated spack-packages to 2024.03.22, spack-config to 2024.02.1
* spack.yaml: Updated access-om2 package version from 2023.11.24 to 2024.03.0


---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tommy Gatti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

@micaeljtoliveira micaeljtoliveira Awaiting requested review from micaeljtoliveira

Assignees

@harshula harshula

Labels
None yet
Projects
ACCESS-OM2 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshula @aidanheerdegen