Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ISSM model and supporting packages #42

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

angus-g
Copy link
Contributor

@angus-g angus-g commented Sep 12, 2023

As mentioned in #20, here is the ISSM package which pulls in PETSc and builds using Intel compilers and MKL on Gadi. The packages.yaml may need to be modified for site configurations to specify that intel-oneapi-mkl uses the +cluster variant in order to include ScaLAPACK and BLACS.

It's also possible that intel-oneapi-mkl can be renamed to something more NCI-specific, like the existing nci-openmpi package.

This is a Fortran optimisation routine, one of the prerequisites for
ISSM.
@aidanheerdegen
Copy link
Member

This is great @angus-g, thanks.

I agree it would be good for the package to be called nci-intel-oneapi-mkl to be clear what it does.

Do you imagine that you'll make a PR for m1qn3 and triangle to the main spack repo?

I'll try and give the build a burl tomorrow.

@angus-g
Copy link
Contributor Author

angus-g commented Sep 14, 2023

Do you imagine that you'll make a PR for m1qn3 and triangle to the main spack repo?

I'll have to verify the license for m1qn3, but I could do that, yes.

@harshula
Copy link
Collaborator

Hi @aidanheerdegen , @angus-g is coming over to the office on Tuesday afternoon to walk-through the PR.

@harshula
Copy link
Collaborator

We did an in-person review today. TODO: Licenses, header comment in patch file, do from spack.package import install, mkdirp instead of from spack.package import *, etc.

packages/issm/package.py Outdated Show resolved Hide resolved
This version of intel-oneapi-mkl overrides the component_prefix
property to work with the non-standard paths used on Gadi.
This is a fairly simple configuration of ISSM, but it demonstrates
building with Intel compilers and MKL to bring in the PETSc
dependency.
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: do from spack.package import install, mkdirp instead of from spack.package import *

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks again @angus-g

@harshula harshula merged commit e8cfd24 into ACCESS-NRI:main Oct 3, 2023
1 check failed
@angus-g angus-g deleted the angus-g/issm branch October 4, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants