Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-esm1p6: add variant cice, generic-tracers and um #177

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

harshula
Copy link
Collaborator

@harshula harshula commented Dec 6, 2024

This PR increases flexibility by allowing the user to make the following choices:

  1. cice = {4,5} (only cice4 has been tested)
  2. generic-tracers = {True,False} (tested)
  3. um = {access-esm1.5,access-esm1.6} (tested)

Closes #175

@harshula harshula self-assigned this Dec 6, 2024
@harshula
Copy link
Collaborator Author

harshula commented Dec 6, 2024

Testing in PR ACCESS-NRI/ACCESS-ESM1.6#15

@aidanheerdegen
Copy link
Member

I was interested in how this is invoked. It looks like to use a different UM version it is necessary to specify it in two places, the spec and the depends

ACCESS-NRI/ACCESS-ESM1.6@4f990d7

spack:
    specs:
       - [email protected]_2024.12.0 um=access-esm1.6
   um7:
      require:
        - '@git.dev-access-esm1.6=access-esm1.6'

and when going from non-generic tracers to generic tracers it is also necessary to change the MOM5 branch

ACCESS-NRI/ACCESS-ESM1.6@3055fde

spack:
    specs:
       - [email protected]_2024.12.0

(Note above changed from [email protected]_2024.12.0 ~generic-tracers

   mom5:
      require:
        - '@git.dev_2024.08.14=access-esm1.6'

@harshula
Copy link
Collaborator Author

harshula commented Dec 6, 2024

Your MOM5 question is answered in a comment:

    # TODO: Use the access-esm1.6 branch when it has been confirmed that
    #       MOM5 master supports building with generic tracers disabled.
    depends_on(
        "[email protected] type=ACCESS-CM",
        type="run",
        when="~generic-tracers",
    )
    depends_on(
        "[email protected] type=ACCESS-ESM",
        type="run",
        when="+generic-tracers",
    )

@harshula
Copy link
Collaborator Author

harshula commented Dec 6, 2024

It looks like to use a different UM version it is necessary to specify it in two places, the spec and the depends

No. The um change is only required in the spack.yaml's packages section. For um, the variant in the SBR is there in case it is needed when not using a spack.yaml. It's almost like documentation.

e.g. ACCESS-NRI/ACCESS-ESM1.6#15 (comment)

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshula harshula merged commit 32bcad8 into main Dec 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Updates to esm1.6 package on UM side
2 participants