Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-ESM1.6 SBD #141

Merged
merged 4 commits into from
Aug 21, 2024
Merged

ACCESS-ESM1.6 SBD #141

merged 4 commits into from
Aug 21, 2024

Conversation

dougiesquire
Copy link
Contributor

This PR adds a new SBD for ACCESS-ESM1.6. At the moment, this is only differs from ACCESS-ESM1.5 in how MOM5 is built.

Closes #140

Copy link
Contributor

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on line 490.

packages/mom5/package.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please do a squash merge.

@dougiesquire
Copy link
Contributor Author

I think I need approval from @penguian to allow the merge

@CodeGat
Copy link
Contributor

CodeGat commented Aug 21, 2024

Admins can dismiss requested changes, if you think he would be happy - just since he's not in this morning

@dougiesquire
Copy link
Contributor Author

I've resolved his review comment, so I think he'd be happy?

@CodeGat CodeGat dismissed penguian’s stale review August 21, 2024 00:41

Dismissing as feedback has been addressed

@CodeGat
Copy link
Contributor

CodeGat commented Aug 21, 2024

Done @dougiesquire

@dougiesquire dougiesquire merged commit 81a820e into main Aug 21, 2024
1 check passed
@dougiesquire dougiesquire deleted the issue140-access-esm1.6-sbd branch August 21, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ACCESS-ESM1.6 SBD
4 participants