Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spack package for cice4 #100

Merged
merged 10 commits into from
May 1, 2024
Merged

Spack package for cice4 #100

merged 10 commits into from
May 1, 2024

Conversation

penguian
Copy link
Contributor

This is a minimal viable product merge for the access-esm1.5 version of cice4.
Closes #87

@penguian penguian linked an issue Apr 29, 2024 that may be closed by this pull request
Spack package for cice4 #87
Closed
@penguian penguian self-assigned this Apr 29, 2024
@penguian penguian requested a review from harshula April 30, 2024 02:20
@penguian
Copy link
Contributor Author

Both files include references to their sources. The command

spack install cice4%[email protected]

successfully build an executable that runs the ACCESS-ESM 1.5 pre-industrial configuration successfully, with bitwise identical output to previous runs, excluding timing.

harshula
harshula reviewed Apr 30, 2024
View reviewed changes
packages/cice4/package.py Outdated Show resolved Hide resolved
@penguian
Copy link
Contributor Author

Rebase to main created a merge conflict in packages/cice4/package.py. I resolved this.
I also re-tested with pre-industrial configuration and output is still bit identical.

@harshula harshula force-pushed the 87-spack-package-for-cice4 branch from 28953c1 to 65be18e Compare May 1, 2024 00:27
@harshula
Copy link
Collaborator

harshula commented May 1, 2024

I've removed the unnecessary rebase merge commit.

harshula
harshula approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash merge the PR and make the commit message as concise as possible.

@penguian penguian merged commit 70599a4 into main May 1, 2024
1 check passed
@penguian penguian deleted the 87-spack-package-for-cice4 branch May 1, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshula harshula harshula approved these changes

Assignees

@penguian penguian

Labels
None yet
Projects
ACCESS-ESM1.5 Spack
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spack package for cice4
2 participants
@penguian @harshula