Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BCI pipeline for Model PRs on main #69

Open
CodeGat opened this issue Aug 23, 2023 · 1 comment
Open

Create BCI pipeline for Model PRs on main #69

CodeGat opened this issue Aug 23, 2023 · 1 comment
Labels
priority:medium A medium priority issue - has some impact on functionality type:feature New feature or request type:investigation look into options, do some research!

Comments

@CodeGat
Copy link
Member

CodeGat commented Aug 23, 2023

Description
One of the stages for open PRs (specifically, on the main branch) on models would be to run cheap BCI tests as the PR is updated. These include Code Unit Tests (where they exist) as well as Semantic and Syntax checks. Find some syntax/semantic checkers that can be used as an action.

For pre-merge checking, the full model build test will be run (in which the version at the tip of the feature branch is 'transplanted' onto the relevant dependency image). This is also run for all dependent models, too. So, for example, if mom5 was updated, access-om2 would also have to be updated as well. (Look up how it would work to transplant multiple pieces into a dependency image (eg. using mom5@=git.feature_branch in the access-om2 environment, which needs to build access-om2@=git.master.

Considerations

  • How long would this pre-merge checking take?
@CodeGat CodeGat added type:feature New feature or request priority:high A high priority issue - has an impact on core functionality type:investigation look into options, do some research! labels Aug 23, 2023
@CodeGat CodeGat self-assigned this Sep 14, 2023
@CodeGat
Copy link
Member Author

CodeGat commented Sep 27, 2023

Unassigning myself to this ticket for the time being as other, higher priority work has come up (namely #5 ) after a standup chat with @aidanheerdegen .
State of the ticket: Chatted to Paul and some other people at ACCESS-NRI about Fortran linting standards and conventions, but hadn't got to a consensus on what standard to use, or even what errors to check for (indeed, finding a decent GHA linter is difficult enough).
One thing that did come up is that we don't want to enforce standards on older models - some of them are almost 10 years old and aren't going to be changed.

@CodeGat CodeGat removed their assignment Sep 27, 2023
@CodeGat CodeGat added priority:medium A medium priority issue - has some impact on functionality and removed priority:high A high priority issue - has an impact on core functionality labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium A medium priority issue - has some impact on functionality type:feature New feature or request type:investigation look into options, do some research!
Projects
None yet
Development

No branches or pull requests

1 participant