Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if pre-merge checking works as expected in GitHub Actions #70

Closed
CodeGat opened this issue Aug 23, 2023 · 1 comment
Closed
Assignees
Labels
priority:blocker A blocker issue - must be resolved and no other work can continue type:investigation look into options, do some research!

Comments

@CodeGat
Copy link
Member

CodeGat commented Aug 23, 2023

Description
Figure out if the on.pull_request.merge_group is all it's cracked up to be. This is going to be used to do heavier checks before a merge, after all reviews have been completed.

Possibly just try with a private repository, although it might only work for organisations. Check out https://github.blog/changelog/2022-08-18-merge-group-webhook-event-and-github-actions-workflow-trigger/

This issue blocks #69

@CodeGat CodeGat added priority:high A high priority issue - has an impact on core functionality type:investigation look into options, do some research! priority:blocker A blocker issue - must be resolved and no other work can continue and removed priority:high A high priority issue - has an impact on core functionality labels Aug 23, 2023
@CodeGat CodeGat self-assigned this Aug 31, 2023
@CodeGat
Copy link
Member Author

CodeGat commented Sep 14, 2023

See the above merged (via queue) for run details.
Merge Queue doesn't seem to be running the if: github.event_name == 'merge_group' checks. See this run specifically: https://github.com/ACCESS-NRI/test/pull/16.

In this case, Merge Groups seem to not be the correct way to go for expensive checks. In this case, we can still do the expensive checks as part of a regular on.pull_request.

Closing.

@CodeGat CodeGat closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:blocker A blocker issue - must be resolved and no other work can continue type:investigation look into options, do some research!
Projects
None yet
Development

No branches or pull requests

1 participant