-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICE config for CICE6.5 #54
Conversation
dd3b3a5
to
1477948
Compare
With CICE-Consortium/CICE#936 this is set by the nuopc driver
…ave a land(ish) mask applied, so are not very useful and slow down multiple history file at once. See CICE-Consortium/CICE#935
…tly be for debugging and C-grid work.
…period they are averaging over. CICE-Consortium/CICE#839
1477948
to
fbb05e0
Compare
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
fbb05e0
to
466cd80
Compare
@aekiss @dougiesquire Can you review please? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anton-seaice - LGTM, sorry for the very slow turnaround
f_tlon = .false. , f_tlat = .false. | ||
f_ulon = .false. , f_ulat = .false. | ||
f_nlon = .false. , f_nlat = .false. | ||
f_elon = .false. , f_elat = .false. | ||
f_tmask = .false. , f_umask = .false. | ||
f_nmask = .false. , f_emask = .false. | ||
f_tarea = .false. , f_uarea = .false. | ||
f_narea = .false. , f_earea = .false. | ||
f_dxt = .false. , f_dyt = .false. | ||
f_dxu = .false. , f_dyu = .false. | ||
f_dxe = .false. , f_dye = .false. | ||
f_dxn = .false. , f_dyn = .false. | ||
f_HTN = .false. , f_HTE = .false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with compression these will be very small, but I take your point about them not being very useful and slowing it down so I'm happy for them to be false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In xarray, when you do a concatenation operation, it does a check that the coordinates are the same in all the datasets. This is very slow, hence the reason for removing them.
Not slow at all :) I only requested it yesterday :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and runs as is, thanks @anton-seaice. Most of these changes are also needed in our other configs. I presume that's the plan?
Thanks dougie. Yes I will go through and cherry-pick these into the other configs and check if there are differences needed. |
Changes described in COSIMA/access-om3#113 for move to CICE 6.5. Uncompressed daily history output is 15MB, compressed is 2MB.
Add new cice grid from COSIMA/esmgrids#6 and (COSIMA/access-om2#279 )
Tigthen grid angle check limits (per COSIMA/access-om3#144)
Add freeboard as a default history output to make validation easier.
Turn off metadata for development work.
Change should be described in each commit, I will not squash the commits.