Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICE config for CICE6.5 #54

Merged
merged 10 commits into from
May 16, 2024
Merged

Conversation

anton-seaice
Copy link
Contributor

@anton-seaice anton-seaice commented Apr 5, 2024

Changes described in COSIMA/access-om3#113 for move to CICE 6.5. Uncompressed daily history output is 15MB, compressed is 2MB.

Add new cice grid from COSIMA/esmgrids#6 and (COSIMA/access-om2#279 )

Tigthen grid angle check limits (per COSIMA/access-om3#144)

Add freeboard as a default history output to make validation easier.

Turn off metadata for development work.

Change should be described in each commit, I will not squash the commits.

@anton-seaice anton-seaice self-assigned this Apr 5, 2024
@anton-seaice anton-seaice changed the title 1deg jra55do iaf iss113 CICE config for CICE6.5 Apr 21, 2024
@anton-seaice anton-seaice force-pushed the 1deg_jra55do_iaf_iss113 branch 2 times, most recently from dd3b3a5 to 1477948 Compare April 26, 2024 01:39
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
@anton-seaice anton-seaice marked this pull request as ready for review May 14, 2024 06:40
@anton-seaice
Copy link
Contributor Author

@aekiss @dougiesquire Can you review please? :)

Copy link
Contributor

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice - LGTM, sorry for the very slow turnaround

Comment on lines +135 to +147
f_tlon = .false. , f_tlat = .false.
f_ulon = .false. , f_ulat = .false.
f_nlon = .false. , f_nlat = .false.
f_elon = .false. , f_elat = .false.
f_tmask = .false. , f_umask = .false.
f_nmask = .false. , f_emask = .false.
f_tarea = .false. , f_uarea = .false.
f_narea = .false. , f_earea = .false.
f_dxt = .false. , f_dyt = .false.
f_dxu = .false. , f_dyu = .false.
f_dxe = .false. , f_dye = .false.
f_dxn = .false. , f_dyn = .false.
f_HTN = .false. , f_HTE = .false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with compression these will be very small, but I take your point about them not being very useful and slowing it down so I'm happy for them to be false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In xarray, when you do a concatenation operation, it does a check that the coordinates are the same in all the datasets. This is very slow, hence the reason for removing them.

@anton-seaice
Copy link
Contributor Author

Thanks @anton-seaice - LGTM, sorry for the very slow turnaround

Not slow at all :) I only requested it yesterday :)

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and runs as is, thanks @anton-seaice. Most of these changes are also needed in our other configs. I presume that's the plan?

@anton-seaice
Copy link
Contributor Author

Thanks dougie. Yes I will go through and cherry-pick these into the other configs and check if there are differences needed.

@anton-seaice anton-seaice merged commit 7115cf5 into 1deg_jra55do_iaf May 16, 2024
@anton-seaice anton-seaice deleted the 1deg_jra55do_iaf_iss113 branch August 20, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants