-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!test
Comment Command
#137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
force-pushed
the
120-!test-comment-command
branch
from
October 17, 2024 03:17
d7a53c8
to
e54cdda
Compare
Co-authored-by: Anton Steketee <[email protected]>
aidanheerdegen
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXCITING!
CodeGat
added a commit
that referenced
this pull request
Oct 18, 2024
CodeGat
added a commit
that referenced
this pull request
Oct 18, 2024
CodeGat
added a commit
that referenced
this pull request
Oct 18, 2024
CodeGat
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a PR comment-command of the form:
which runs a repro test comparing the
HEAD
of the source (PR) branch against the last common ancestor of the target (merged-into) branch, and optionally commits the result to the PR that the comment was found in.This allows repro checks to be run on any branch, rather than just being automatically run on
dev-*
->release-*
PRs.Appropriate safeguards have been taken so that the comment command will only work for users who have
write
/admin
permissions on the PR they are commenting on.In this PR:
!test
comment commandsRequires ACCESS-NRI/model-config-tests#73
References #120