Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CICE Grid for 01deg ryf #98

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

anton-seaice
Copy link

@anton-seaice anton-seaice commented Apr 17, 2024

Contributes to #92

@anton-seaice anton-seaice changed the title New CICE Grid New CICE Grid for 01deg ryf Apr 17, 2024
aidanheerdegen
aidanheerdegen previously approved these changes Apr 18, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidanheerdegen aidanheerdegen changed the base branch from release-01deg_jra55_ryf to dev-01deg_jra55_ryf April 18, 2024 04:27
@aidanheerdegen aidanheerdegen dismissed their stale review April 18, 2024 04:27

The base branch was changed.

@aidanheerdegen
Copy link
Member

@CodeGat pointed out this was a PR directly to release. Should be dev-, have changed the base and will re-review.

@anton-seaice
Copy link
Author

Thankyou. I knew i would get one wrong !

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make the change indicated? Thanks!

metadata.yaml Outdated
Run with JRA55-do v1.4.0 RYF9091 (1 May 1990 - 30 April 1991) repeated forcing
with all solid runoff converted to liquid runoff with no heat transfer.
Spin up starts from a nominal year of 1 Jan 1900.
description: "0.1 degree ACCESS-OM2 global model configuration under the RYF9091 Repeat\nYear Forcing strategy outlined by Stewart et al. (2020), \nhttps://doi.org/10.1016/j.ocemod.2019.101557.\nThe configuration is based on that described in Kiss et al. (2020),\nhttps://doi.org/10.5194/gmd-13-401-2020, but with many improvements.\nInitial conditions are WOA13v2 potential temperature and practical salinity.\nRun with JRA55-do v1.4.0 RYF9091 (1 May 1990 - 30 April 1991) repeated forcing\nwith all solid runoff converted to liquid runoff with no heat transfer.\nSpin up starts from a nominal year of 1 Jan 1900."
Copy link
Member

@aidanheerdegen aidanheerdegen Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the GitHub bot commit did a bad thing and replaced newlines with \n characters. We don't know why it did this, and it isn't your fault, but could you fix it in this PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done :)

@aidanheerdegen
Copy link
Member

Thankyou. I knew i would get one wrong !

Actually it was really helpful, as it highlighted a logic error in the CI which should have refused to allow the PR (we only want PRs into release- branches to be able to come from the corresponding dev- branch).

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aidanheerdegen aidanheerdegen merged commit 3b299b0 into dev-01deg_jra55_ryf Apr 18, 2024
8 checks passed
@aidanheerdegen aidanheerdegen deleted the update-01deg_jra55_ryf-iss92 branch April 18, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants