-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CICE grids #92
Comments
Great work, and the metadata is much improved, thanks. I did chuck it through cf-xarray to see what it made of it:
Are we happy with that? It can't determine axes. If that was desirable there would need to be variables added for A potential motivation to have The COSIMA Recipe Tutorial for writing model agnostic code is worth a look: as the ice data poses issues because it is quite different to the MOM outputs. Some of the differences that needed to be accounted for:
I ran the file through the CF compliance checker Details
It is notoriously picky, and designed for published data, but some of the suggestions of global attributes seem reasonable, e.g license, date_created |
Hey @bschroeter any opinions about what metadata should be included? We should probably start using something like axiom to validate against a schema https://axiom.readthedocs.io/en/latest/schemas/schemas.html Though that is a much wider problem, so have created an issue |
Yes. That is correct. There are a few things to note:
I obviously can't solve that here.
We might be able to change this. Ill catch this in COSIMA/esmgrids#16
I obviously can't solve that here either.
We will look at this in more detail for OM3 in conjunction with looking at the output files. For OM2, we are releasing the current configuration and don't need to do anything further. |
All related PRs are merged so will close. |
Per COSIMA/om3-utils#5, there are updated cice grids at all resolutions, this requires updating all 0.1 and 1 degree config.yaml files. (0.25 is implemented in #17)
The text was updated successfully, but these errors were encountered: