Set serializable isolation when punishing

A248 · Oct 26, 2023 · d1df238 · d1df238
1 parent 2985be9
commit d1df238
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/...c/main/java/space/arim/libertybans/core/database/execute/RollbackTrackingTransaction.java b/...c/main/java/space/arim/libertybans/core/database/execute/RollbackTrackingTransaction.java
@@ -43,6 +43,15 @@ boolean wasNotRolledBack() {
 		return !rolledBack;
 	}
 
+	@Override
+	public void setIsolation(int level) {
+		try {
+			connection.setTransactionIsolation(level);
+		} catch (SQLException ex) {
+			throw new DataAccessException("Failed to set isolation", ex);
+		}
+	}
+
 	@Override
 	public void rollback() {
 		try {
@@ -88,6 +97,11 @@ private NestedTransaction(Savepoint savepoint) {
 			this.savepoint = Objects.requireNonNull(savepoint, "savepoint");
 		}
 
+		@Override
+		public void setIsolation(int level) {
+			throw new UnsupportedOperationException("Cannot set isolation levels in nested transactions");
+		}
+
 		@Override
 		public void rollback() {
 			try {

diff --git a/bans-core/src/main/java/space/arim/libertybans/core/database/execute/Transaction.java b/bans-core/src/main/java/space/arim/libertybans/core/database/execute/Transaction.java
@@ -26,6 +26,13 @@
  */
 public interface Transaction {
 
+	/**
+	 * Sets the isolation level on this transaction
+	 *
+	 * @param isolationLevel the isolation level
+	 */
+	void setIsolation(int isolationLevel);
+
 	/**
 	 * Rolls back the enclosing scope
 	 *

diff --git a/bans-core/src/main/java/space/arim/libertybans/core/punish/Enactor.java b/bans-core/src/main/java/space/arim/libertybans/core/punish/Enactor.java
@@ -106,6 +106,9 @@ CentralisedFuture<Punishment> enactPunishment(DraftPunishment draftPunishment) {
 				creator);
 
 		return database.queryWithRetry((context, transaction) -> {
+			// Make sure concurrent executions do not conflict
+			transaction.setIsolation(Connection.TRANSACTION_SERIALIZABLE);
+
 			if (type != PunishmentType.KICK) {
 				database.clearExpiredPunishments(context, type, start);
 			}
@@ -124,6 +127,8 @@ CentralisedFuture<Punishment> calculatePunishment(CalculablePunishment calculabl
 
 		InternalDatabase database = dbProvider.get();
 		return database.queryWithRetry((context, transaction) -> {
+			// Make sure concurrent executions do not conflict
+			transaction.setIsolation(Connection.TRANSACTION_SERIALIZABLE);
 
 			var calculationResult = calculablePunishment.getCalculator().compute(
 					escalationTrack, victim,