Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand taskfile #377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

expand taskfile #377

wants to merge 3 commits into from

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Oct 30, 2024

I am adding a new task into the Taskfile.yml inside .dagger-ci directory, which simplifies building single docker containers (mostly for development purposes).

I am also linking the the two taskfiles (the main one and one in the .dagger-ci directory) for simplicity.

Building coreboot containers will be a bit problematic after the #343 is merged because it will require to have pre-compiled tool-chain ready on disk :(

@AtomicFS AtomicFS requested a review from MDr164 as a code owner October 30, 2024 11:03
@AtomicFS AtomicFS changed the title Feat/taskfile expand taskfile Oct 30, 2024
@github-actions github-actions bot added feature New feature or request python Pull requests that update Python code labels Oct 30, 2024
internal: true
cmds:
- python -m venv {{.PYTHON_VENV}}
- bash -c "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those multiline cmds working without \ at the end or prefixing it with the yaml | syntax? Looks like GitHubs syntax highlighter does not like it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem to work ... works on my machine xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants