Fix bugs introduced in v2.7.0 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaolin
requested review from
ChriMarMe,
walterchris,
flanfly,
PatrickRudolph and
ArthurHeymans
as code owners
ChriMarMe
requested changes
Mar 15, 2023
xaionaro
approved these changes
May 10, 2023
This was referenced Sep 5, 2023
|
What's the blocker here? 👀 |
|
I want to merge it this week. Can you rebase and fix conflicts @zaolin ? |
walterchris
force-pushed
the
fixes-2.7.0
branch
from
a73733d
to
13131fa
Compare
A couple of things broke while adding bg-suite - let's fix it up. Signed-off-by: Philipp Deppenwiese <[email protected]> Signed-off-by: Christian Walter <[email protected]>
walterchris
force-pushed
the
fixes-2.7.0
branch
from
13131fa
to
7df8824
Compare
Signed-off-by: Christian Walter <[email protected]>
ChriMarMe
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After gathering more feedback fix remaining issues: