Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if plugin supports expected interface Id when enabling #74

Merged
merged 55 commits into from
Aug 23, 2023
Merged

Check if plugin supports expected interface Id when enabling #74

merged 55 commits into from
Aug 23, 2023

Conversation

akshay-ap
Copy link
Contributor

Fixes: #73

Changes in PR:

  • Check if plugin supports appropriate interface id when enabling in manager
  • Update tests

akshay-ap added 30 commits July 26, 2023 15:27
@akshay-ap
[#46] Implement Guard interface in SafeProtocolManager
f7aadcf
@akshay-ap
[#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolMa…
175d0b9 
…nager
@akshay-ap
[#47] Create BaseManager contract, rename modifier, rename error, che…
ef92c98 
…ck registry while adding function handler
@akshay-ap
[#47] Update natspec doc
5a52eef
@akshay-ap
Merge branch 'main' of github.com:5afe/safe-protocol into feature-46-…
2d4a1a1 
…hooks-for-multisig-flow
@akshay-ap
[#46] Setup Safe
1692fe0
@akshay-ap
Merge branch 'main' of github.com:5afe/safe-protocol into feature-46-…
579ef82 
…hooks-for-multisig-flow
@akshay-ap
[#46] Fix EOF
1d73328
@akshay-ap
[#46] User setupTest function
89fba60
@akshay-ap
[#46] Fix lint issue
6beead3
@akshay-ap
[#46] Add tests
4ceb3e3
@akshay-ap
[#46] Add test with delegateCall for hooks flow
69ed0db
@akshay-ap
[#46] User temporary variable for storing hooks address
3c2e2d6
@akshay-ap
Merge branch 'feature-46-hooks-for-multisig-flow' of github.com:5afe/…
6624509 
…safe-protocol into feature-47-support-function-handlers
@akshay-ap
[#47] Implement logic for non-static calls to function handler manage…
69e227c 
…r, test to set function handler
@akshay-ap
[#47] Add tests for Function Handler
8bf6053
@akshay-ap
Merge branch 'main' of github.com:5afe/safe-protocol into feature-47-…
446084d 
…support-function-handlers
@akshay-ap
[#47] Pass sender address in handle function
4a05518
@akshay-ap
[#47] Fix test
77d0b54
@akshay-ap
[#47] Use ZeroAddress from ethers
b406518
@akshay-ap
[#46] Reset tempHooksAddress
55ef824
@akshay-ap
[#47] Test static call to function handler
675fe12
@akshay-ap
[#47] Fix lint issue
0af2503
@akshay-ap
Merge branch 'feature-46-hooks-for-multisig-flow' of github.com:5afe/…
6e98d70 
…safe-protocol into feature-47-support-function-handlers
@akshay-ap
[#47] Fix typo
842c2ad
@akshay-ap
[#46] Refactor tests for SafeProtocolManager as Guard
f826f98
@akshay-ap
Merge branch 'main' of github.com:5afe/safe-protocol into feature-46-…
6eb0388 
…hooks-for-multisig-flow
@akshay-ap
[#46] Fix failing test
98c24cc
@akshay-ap
Merge branch 'feature-46-hooks-for-multisig-flow' of github.com:5afe/…
08ee3de 
…safe-protocol into feature-47-support-function-handlers
@akshay-ap
[#46] Update comment
dc14c0d
@akshay-ap akshay-ap added the enhancement New feature or request label Aug 21, 2023
@akshay-ap akshay-ap requested review from rmeissner and mmv08 August 21, 2023 14:39
@akshay-ap akshay-ap self-assigned this Aug 21, 2023
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link

coveralls commented Aug 21, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same when pulling f44918a on feature-73-eip165-check-for-plugin into ea7f2c3 on main.

@rmeissner rmeissner added this to the v0.2.0 milestone Aug 22, 2023
@akshay-ap akshay-ap changed the base branch from feature-47-support-function-handlers to main August 22, 2023 09:19
@akshay-ap akshay-ap requested a review from mmv08 August 23, 2023 09:52
mmv08
mmv08 approved these changes Aug 23, 2023
View reviewed changes
test/SafeProtocolManager.spec.ts Show resolved Hide resolved
@akshay-ap akshay-ap added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 1fdfc1b Aug 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@akshay-ap akshay-ap deleted the feature-73-eip165-check-for-plugin branch August 23, 2023 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

ERC165 check when enabling plugin
4 participants
@akshay-ap @coveralls @mmv08 @rmeissner