Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: state mutability and unused var #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: state mutability and unused var #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
920e8e5
perf: restrict state mutability to `pure`
gosuto-inzasheru Mar 21, 2024
a045e28
perf: remove unused variable
gosuto-inzasheru Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/SafeProtocolRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ contract SafeProtocolRegistry is ISafeProtocolRegistry, Ownable2Step {
emit ModuleFlagged(module);
}

function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
function supportsInterface(bytes4 interfaceId) external pure override returns (bool) {
return interfaceId == type(ISafeProtocolRegistry).interfaceId || interfaceId == type(IERC165).interfaceId;
}
}
2 changes: 1 addition & 1 deletion contracts/SignatureValidatorManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ contract SignatureValidatorManager is RegistryManager, ISafeProtocolFunctionHand
* @param interfaceId bytes4 interface id to be checked
* @return true if interface is supported
*/
function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
function supportsInterface(bytes4 interfaceId) external pure override returns (bool) {
return
interfaceId == type(IERC165).interfaceId ||
interfaceId == type(ISafeProtocolSignatureValidatorManager).interfaceId ||
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/TestFallbackReceiver.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ contract TestFallbackReceiver {

receive() external payable {
// solhint-disable-next-line no-unused-vars
(bool success, bytes memory data) = ethReceiver.call{value: address(this).balance}("");
(bool success, ) = ethReceiver.call{value: address(this).balance}("");
if (!success) {
revert("Failed to send eth");
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/test/TestPlugin.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ abstract contract BaseTestPlugin is ISafeProtocolPlugin {
permissions = _requiresPermission;
}

function supportsInterface(bytes4 interfaceId) external view override returns (bool) {
function supportsInterface(bytes4 interfaceId) external pure override returns (bool) {
return interfaceId == type(ISafeProtocolPlugin).interfaceId || interfaceId == 0x01ffc9a7;
}

Expand Down
Loading