Split text input padding into 2 separate properties #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementPasteau
approved these changes
Jan 23, 2025
AlexandreSi
force-pushed
the
fix-input-outline
branch
from
d4b8430 to
d0915e1
Compare
| @@ -135,7 +135,10 @@ namespace gdjs { | |||
| this._readOnly = objectData.content.readOnly; | |||
| this._textAlign = parseTextAlign(objectData.content.textAlign); //textAlign is defaulted to 'left' by the parser if undefined. | |||
| this._maxLength = objectData.content.maxLength || 0; //maxlength and padding require a default value as they can be undefined in older projects. | |||
| this._padding = objectData.content.padding || 0; | |||
| this._padding = | |||
| objectData.content.padding !== undefined | |||
There was a problem hiding this comment.
Is this for clarity of code, or does behavior changes too ?
There was a problem hiding this comment.
Now that the default value is 1, if I had kept the check like this: objectData.content.padding || 1
If the user entered the value 0, objectData.content.padding would be falsy, so the padding would get the value 1. That's where the undefined check comes in useful
AlexandreSi
changed the title
4ian
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result:
Also: