Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency on arrows #7322

Merged
merged 21 commits into from
Jan 24, 2025
Merged

Consistency on arrows #7322

merged 21 commits into from
Jan 24, 2025

Conversation

Bouh
Copy link
Collaborator

@Bouh Bouh commented Jan 17, 2025

All changed are made accoring to the design, expect for some because I don't know how to manage them:

  • The behavior in the object dialog, that use Accordion from Material-UI that auto flip the icon.
  • The select list, that use Material-UI too, I can see the select and the option inside but I can't find where is the icon.

// TODO

  • The eventsheet are using images, I need to replace them and handle padding/background colours. I used SVG as recommended.

@Bouh Bouh requested a review from 4ian as a code owner January 17, 2025 17:46
@AlexandreSi
Copy link
Collaborator

Using ChevronArrowXXX in TreeView required to increase the size of the SVG so that it's not too small, which is a good thing because the clicking area is increased, but a bad thing because it messed up the alignment of icons.
I think those icons in the TreeView (and ReadOnlyTreeView now also) should be handled directly with SVG outside of material-ui.

@AlexandreSi AlexandreSi merged commit 0848a10 into master Jan 24, 2025
5 of 6 checks passed
@AlexandreSi AlexandreSi deleted the arrows branch January 24, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants