[WIP] Finalizing/Testing of TwistController features #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llision with mild.dae.
…b_control into mesh_repr_of_registered_links
…than 255 that's why 2^16 had been chosen.
…ipa-fxm-cm/cob_control into test_of_features
…b_control into test_of_features
…ipa-fxm/cob_control into test_test_of_feature
…convertMoveLinRelToAbs method again (why removed?)
…tead of holdPosition action
…- Corrected pose update for self collision check frames. - Added new scripts.
- Moved scripts to subfolder test.
…:ipa-fxm-mb/cob_control into test_of_feature
| # goal.move_lin.profile.profile.accl = 0.1 | ||
| # goal.move_lin.profile.profile_type = Profile.SINOID | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Do we still use this script? Or is it superseded by those in cob_twist_controller/scripts/test?
If it's not needed, I'd remove it...or at least split it maybe...
|
For enhancements/open issues regarding Same for enhancements of |
| //} | ||
| // | ||
| //ht_.hold = abortion_counter_ >= max_abortions_; | ||
| //publishTwist(period, !ht_.hold); // if not publishing then just update data! |
There was a problem hiding this comment.
What function does this code block belong to? Remove?
…roller features (4am-robotics#51). Renaming from frame_to_collision to link_to_collision.
…:ipa-fxm-mb/cob_control into test_of_feature
fmessmer
added a commit
that referenced
this pull request
Aug 25, 2015
[WIP] Finalizing/Testing of TwistController features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP/CodeReview PR that still needs some more tweaking. Do not merge yet!
(Mainly motivated by @ipa-fxm-mb finalizing his thesis soon)
Also, all remaining issues regarding package_xml_migration will be handled here for the following packages (as I keep merging back and forth all the time):
@ipa-fxm-mb FYI