Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rospy.sleep exception handling #169

Merged
merged 2 commits into from
Jan 25, 2017
Merged

rospy.sleep exception handling #169

merged 2 commits into from
Jan 25, 2017

Conversation

fmessmer
Copy link
Contributor

some sleep() exception handling which prevents a lot of terminal output on "STRG+C"

mgruhler
mgruhler reviewed Jan 19, 2017
View reviewed changes
cob_dashboard/scripts/cob_dashboard_aggregator.py
try:
r.sleep()
except rospy.exceptions.ROSInterruptException as e:
#print "ROSInterruptException", e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove this line (same below)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied it from some other script which had it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convinced: it's cleaner without

@fmessmer fmessmer force-pushed the python_exception_handling branch from d573c99 to 0ebe0e2 Compare January 20, 2017 08:14
@fmessmer fmessmer force-pushed the python_exception_handling branch from 631fde0 to a7ca78d Compare January 20, 2017 19:09
@fmessmer
Copy link
Contributor Author

fmessmer commented Jan 20, 2017 •
edited
Loading

Added proper from __future__ import print_function as suggested in https://github.com/ipa320/cob_control/issues/129#issuecomment-274029626 and python_2_and_3_compatible_code

@floweisshardt floweisshardt merged commit 64032d2 into 4am-robotics:indigo_dev Jan 25, 2017
@fmessmer fmessmer mentioned this pull request Jan 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgruhler mgruhler mgruhler left review comments

@ipa-nhg ipa-nhg ipa-nhg approved these changes

@floweisshardt floweisshardt floweisshardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmessmer @floweisshardt @ipa-nhg @mgruhler