Sohyupar spring #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssuamje
reviewed
Jan 10, 2024
There was a problem hiding this comment.
LV 1 : 설명도 잘 작성해주셨고 다 맞습니다..! @value에서 default 값 지정해주는 부분은 저도 처음 알았어요bb
LV 2 : 서비스 자체에서 꼭 필요한 경우가 아니면 private 메서드로 굳이 빼지 않는 게 더 좋을 것 같습니다(아래로 내려놓으면 오히려 이해하기 어려울 수 있음, 그리고 private이 많아진다는 얘기는 서비스의 책임이 무거워졌다는 뜻) && lentHistoryRepository에서 userId를 기준으로 find(optional 반환)하는 방식으로 작성해주셨어도 좋을 것 같습니다! 이외에는 더 말씀드릴게 없어요..
LV 3 : 다 맞게 작성하셨습니다..!
온보딩 고생하셨습니다!! she is gosu
Ssuamje
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 끄..ㅌ?