Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Start SMS Conversation": allow selection of SMS provider #7

Open
twomice opened this issue Aug 9, 2017 · 2 comments
Open

"Start SMS Conversation": allow selection of SMS provider #7

twomice opened this issue Aug 9, 2017 · 2 comments

Comments

@twomice
Copy link

twomice commented Aug 9, 2017

Seems like this should be do-able by adding a form field and some logic to support it, as is already done in the native "Send SMS" activity. Are you open to PR for this?
@michaelmcandrew
Copy link
Collaborator

Yes - along with some accompanying tests :)

twomice added a commit to twomice/civicrm-sms-conversation that referenced this issue Aug 10, 2017
@twomice
Toward 3sd#7: allow selection of SMS provider.
1f00da4
twomice added a commit to twomice/civicrm-sms-conversation that referenced this issue Aug 10, 2017
@twomice
Toward 3sd#7: allow selection of SMS provider.
cf89b27
@twomice
Copy link
Author

twomice commented Aug 10, 2017

Working on it now. https://github.com/twomice/civicrm-sms-conversation/tree/7_select_sms_provider

POC works; need to figure out how to test it and write tests.

twomice added a commit to twomice/civicrm-sms-conversation that referenced this issue Aug 10, 2017
@twomice
Toward 3sd#7: Bug-fix: bad arguments caused fatal error for subsequen…
699e1cb 
…t questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelmcandrew @twomice