👷 [portafly] fixes build and adds a new job to the pipeline

3scale · Jul 17, 2020 · e866b6d · e866b6d
1 parent 8589e74
commit e866b6d
Show file tree

Hide file tree

Showing 3 changed files with 456 additions and 510 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -828,7 +828,7 @@ jobs:
           path: tmp/capybara
           destination: capybara
 
-  portafly:
+  portafly_tests:
     resource_class: small
     docker:
       - image: circleci/node:12
@@ -841,9 +841,25 @@ jobs:
           command: |
             cd portafly
             yarn --version
-            yarn install
+            yarn install --frozen-lockfile
             yarn test --maxWorkers=3
 
+  portafly_build:
+    resource_class: small
+    docker:
+      - image: circleci/node:12
+    parameters:
+    steps:
+      - checkout-with-submodules
+      - run:
+          name: Run PortaFly Build
+          root: .
+          command: |
+            cd portafly
+            yarn --version
+            yarn install --frozen-lockfile
+            CI=false yarn build
+
   check_production_gemfile:
     parameters:
       executor:
@@ -1139,16 +1155,19 @@ workflows:
             - assets_precompile
           <<: *only-master-filter
 
-  portafly_build:
+  portafly:
     jobs:
       - manual_approval:
           type: approval
       - notify_start:
           requires:
             - manual_approval
-      - portafly:
+      - portafly_tests:
           requires:
             - manual_approval
+      - portafly_build:
+          requires:
+            - portafly_tests
 
   production_gemfile-master:
     jobs:

diff --git a/portafly/package.json b/portafly/package.json
@@ -88,10 +88,10 @@
     "ts-pnp": "1.2.0",
     "typescript": "~3.8.3",
     "url-loader": "4.1.0",
-    "webpack": "4.43.0",
+    "webpack": "4.42.0",
     "webpack-dev-server": "3.10.3",
     "webpack-manifest-plugin": "2.2.0",
-    "workbox-webpack-plugin": "5.1.3",
+    "workbox-webpack-plugin": "4.3.1",
     "yaml-loader": "^0.6.0"
   },
   "scripts": {