Pin aws s3 module version to current latest, so current TF configs ar…

…e not broken because of using latest s3 module with possible breaking changes
3scale-ops · Sep 7, 2021 · 5b2f032 · 5b2f032
1 parent c773502
commit 5b2f032
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/main.tf b/main.tf
@@ -11,6 +11,7 @@ module "cloudtrail_label" {
 ## Cloudtrail bucket
 module "cloudtrail_bucket" {
   source                  = "terraform-aws-modules/s3-bucket/aws"
+  version                 = "v2.9.0"
   bucket                  = module.cloudtrail_label.id
   acl                     = "private"
   block_public_acls       = true
@@ -241,7 +242,7 @@ data "aws_iam_policy_document" "cloudtrail_kms_policy" {
 ## Cloudtrail
 resource "aws_cloudtrail" "cloudtrail" {
   name                          = module.cloudtrail_label.id
-  s3_bucket_name                = module.cloudtrail_bucket.this_s3_bucket_id
+  s3_bucket_name                = module.cloudtrail_bucket.s3_bucket_id
   include_global_service_events = true
   is_multi_region_trail         = true
   enable_logging                = var.enable_logging

diff --git a/outputs.tf b/outputs.tf
@@ -1,4 +1,4 @@
 
 output "cloudtrail_bucket_name" {
-  value = module.cloudtrail_bucket.this_s3_bucket_id
+  value = module.cloudtrail_bucket.s3_bucket_id
 }