[Bug] Permalink: encode layers style before hash comparison #4894
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
added
sponsored development
rldhont
approved these changes
Oct 22, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain comparison between
window.location.hashand hash stored inPermalink_hashpropertyhttps://github.com/3liz/lizmap-web-client/blob/7bb076d4811fbf4f60c68213dcc1e95116f00f02/assets/src/modules/Permalink.js#L42C21-L42C55
does not work if a layer style contains spaces or other "special" chars.
If the hash comparison fails, the hash change could be triggered over and over again. This could also be enforced by the fact that the
extensionpermalink parameter is converted inEPSG:4326from project CRS and converted again to project CRS to set the map extension. In this conversion process, the original coordinates stored in the permalink may be transformed due to roundingBackport to 3.8
Funded by Faunalia