Action: allow geometry drawn by user #4754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nboisteault
force-pushed
the
action-digitizing
branch
from
ae6f2c2
to
0a2334d
Compare
nboisteault
force-pushed
the
action-digitizing
branch
from
0a2334d
to
7f85468
Compare
nboisteault
force-pushed
the
action-digitizing
branch
2 times, most recently
from
3d5921c
to
01715ca
Compare
nboisteault
force-pushed
the
action-digitizing
branch
from
01715ca
to
44a5636
Compare
nboisteault
force-pushed
the
action-digitizing
branch
from
2bd04d5
to
ca46e6f
Compare
rldhont
approved these changes
Oct 15, 2024
|
waiting for @mdouchin review! |
mdouchin
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for your work.
Can you please improve the UI a bit :
- use the same space between the left mini-dock border and the digitizing toolbar (and message underneath) as the space used for the combobox and "grey" description. It seems. Be careful about testing it with a without Bootstrap 5
- we shoud probably remove the grey background color of the description and use a lighter style, for example a thin blue border as used in the editing form group
border: 1px solid var(--color-contrasted-elements-light);
border-radius: 5px;Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funded by WPD
simplescreenrecorder-2024-10-01_15.20.13.mp4