Check that provider has set wal_level=logical and otherwise immediately fail in pglogical.create_subscription. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if attempting to create a subscription to a node that has not set
wal_level=logical, the call topglogical.create_subscriptionwill succeed, but the node will appear in adownstate and users will have to check the logs to see that the replication slot was unable to be created because the provider haswal_level < logical.Since we already synchronously connect to the provider when creating a subscription, there's no reason to not verify that they have the correct
wal_levelsetting, and immediately tell the user what is wrong.