Add Hz counter to Classic modes (2) #1184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MrZ626
reviewed
Dec 28, 2024
|
|
||
| setFont(20) | ||
| GC.mStr( | ||
| { |
There was a problem hiding this comment.
{ } appearing in codes that runs every frame can lead to performance issues
There was a problem hiding this comment.
Yeah but the text can kinda shift around so what do you suggest I should do?
There was a problem hiding this comment.
for the color table {1,1,1}, you can simply replace them with pre-defined table like COLOR.Z
for the whole string table, you can pre-define them in the file, then change each value before using it
|
And, can this feature be implemented in the shared ruleset file, instead of copy-paste them to every mode file? (I haven't checked it carefully yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#744 with mode modern hooks