Skip to content

Commit

Permalink
fix: unnecessary run scripts warnings (#20)
Browse files Browse the repository at this point in the history
* fix warnings

* check for github CI seems to wor, allows local prod build

* remove double asc
  • Loading branch information
lesleyrs authored Jul 23, 2024
1 parent 21d81ee commit 2cff17c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@
"build": "npm run asc && webpack --mode=production --node-env=production",
"build:dev": "npm run asc && webpack --mode=development",
"build:prod": "npm run asc && webpack --mode=production --node-env=production",
"dev": "npm run asc && webpack-dev-server --hot --watch",
"dev": "npm run asc && webpack-dev-server --hot",
"lint": "eslint . --ext .ts",
"lint:fix": "eslint . --ext .ts --fix",
"format": "prettier src/**/*.{js,ts} --write",
"prepare": "husky install",
"test": "npm run asc && jest",
"asc": "asc --target release --optimizeLevel 3 --converge",
"local": "npm run asc && npm run build:dev && npx serve public"
"local": "npm run build:dev && npx serve public"
},
"repository": {
"type": "git",
Expand All @@ -68,8 +68,7 @@
"lint-staged": {
"src/**/*.{js,ts}": [
"npm run format",
"npm run lint:fix",
"git add"
"npm run lint:fix"
]
}
}
2 changes: 1 addition & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const config = {

output: {
path: path.resolve(__dirname, 'public'),
publicPath: isProduction ? '/Client2/' : '/' // used for GitHub Pages, maybe control via env var?
publicPath: process.env.CI ? '/Client2/' : '/'
},

devServer: {
Expand Down

0 comments on commit 2cff17c

Please sign in to comment.