-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-975] Add library to handle bytes storage slices #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 97.33% 97.56% +0.23%
==========================================
Files 12 14 +2
Lines 263 288 +25
Branches 60 62 +2
==========================================
+ Hits 256 281 +25
Misses 7 7 ☔ View full report in Codecov by Sentry. |
zZoMROT
changed the title
Add library to handle bytes storage slices
[SC-975] Add library to handle bytes storage slices
Nov 2, 2023
ZumZoom
requested changes
Nov 15, 2023
Co-authored-by: Mikhail Melnik <[email protected]>
Co-authored-by: Mikhail Melnik <[email protected]>
# Conflicts: # package.json
# Conflicts: # package.json
# Conflicts: # package.json
ZumZoom
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this library functionality will be implemented as a Solidity language feature in the future: ethereum/solidity#7423
Notes:
BytesStorage.Slice.offset
andBytesStorage.Slice.length
can be packed into a single 32-bytes wordBytesMemory.Slice.pointer
andBytesMemory.Slice.length
can be packed into a single 32-bytes word and stored in UDT on stack, not in memory