fix: Failed to save the Qianfan large model

[shaohuzhang1]

fix: Failed to save the Qianfan large model

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code snippet has a few issues and can be optimized:

Issues found:

1. Incorrect usage of __containsgettext:
   • The correct method to check for membership in a list is in, not __containsgettext.
2. String interpolation using {} instead of %s:
   • Using string formatting with curly braces ({}) is generally considered more modern and readable compared to old-style format strings.
3. Redundant parentheses around gettext('...'.format(...)):
   • These can be omitted.

Optimizations:

1. Inline error message construction in exceptions:
   • It's better practice to inline the error messages directly inside the exception constructor rather than concatenating them outside.

Here's the corrected and optimized version of the code:

def is_valid(self, model_type: str, model_name, model_credential: Dict[str, object], model_params):
    # Check if the model type is supported
    if model_type not in self.supported_models():
        raise AppApiException(ValidCode.invalid_error.value,
                              gettext('{model_type} Model type is not supported')

    # Get the model instance
    model = provider.get_model(model_type, model_name, model_credential, **model_params)

    # Get a sorted list of available models (case-insensitive) from the client
    model_info = [model.lower() for model in sorted(model.client.models())]

    # Check if the requested model name exists
    if model_name.lower() not in model_info:
        raise AppApiException(ValidCode.valid_error.value,
                              gettext('{model_name} The model does not support'.format(model_name=model_name)))

    # Iterate over keys required for authentication
    for key in ['api_key', 'secret_key']:

Additional Considerations:

• Ensure that self.supported_models() returns a valid set or list of supported model types.
• Make sure that provider.get_model() correctly retrieves the model based on the provided parameters.
• Consider adding logging to help diagnose any issues that may arise during execution.