Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: application workflow node params #2087

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

shaohuzhang1
Copy link
Contributor

fix: application workflow node params

Copy link

f2c-ci-robot bot commented Jan 23, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 2c4d1fa into main Jan 23, 2025
4 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@main@fix_workflow_node branch January 23, 2025 05:55
@@ -116,6 +116,9 @@ const validate = () => {
props.nodeModel.graphModel.eventCenter.on('refresh_incoming_node_field', () => {
options.value = getIncomingNode(props.nodeModel.id)
})
props.nodeModel.graphModel.eventCenter.on('refreshFileUploadConfig', () => {
options.value = getIncomingNode(props.nodeModel.id)
})
defineExpose({ validate })
onMounted(() => {
options.value = getIncomingNode(props.nodeModel.id)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet is almost correct, but there are a couple of improvements that could be made:

  1. The validate function should return true to indicate successful validation if needed.

  2. A comment explaining why the event listener for 'refreshFileUploadConfig' is added might help improve readability.

Here's the revised code with these suggestions:

const validate = () => {
  // Implement any necessary logic here for validating node data
  // Return true to indicate successful validation if applicable
}

const { options } = useOptions()

props.nodeModel.graphModel.eventCenter.on('refresh_incoming_node_field', () => {
  options.value = getIncomingNode(props.nodeModel.id)
})

// Event listener for refreshing file upload configurations (optional comment)
props.nodeModel.graphModel.eventCenter.on('refreshFileUploadConfig', () => {
  options.value = getIncomingNode(props.nodeModel.id)
})

defineExpose({
  validate
})

onMounted(() => {
  options.value = getIncomingNode(props.nodeModel.id)
}

Additional optimizations:

  • Ensure that the getIncomingNode function is properly implemented and returns the expected data structure.

  • If you're using Vue components, consider wrapping this逻辑 within hooks or computed properties to keep it organized.

Make sure all dependencies (useOptions, prop, etc.) are correctly imported or defined in your context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant