fix: application i18n #2086
fix: application i18n #2086
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if not text: | ||
| raise AppApiException(500, __('Text-to-speech node, the text content cannot be empty')) | ||
| raise AppApiException(500, _('Text-to-speech node, the text content cannot be empty')) | ||
| result = '\n'.join(line for line in text.split('\n') if line.strip()) | ||
| return markdown_to_plain_text(result) | ||
|
|
There was a problem hiding this comment.
The provided code snippet looks generally clean and free of obvious errors. However, here's one minor suggestion for clarity:
On lines 86 and 87:
if not text:It would be more idiomatic to use if not text.strip() instead, which would also check for empty strings after stripping leading/trailing whitespace.
This change will make it clear that the function should handle cases where a user might enter extra spaces at the beginning or end without them being recognized as an "empty" value. This is especially important if the subsequent processing depends on whether the input is considered non-empty (e.g., splitting or transcoding).
fix: application i18n