Merge pull request #1 from 18F/passive-event-handlers

make scroll and wheel events passive
18F · Nov 8, 2016 · 8f88f3b · 8f88f3b
2 parents 3e7c488 + ed366ec
commit 8f88f3b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/dist/stickyfill.js b/dist/stickyfill.js
@@ -74,7 +74,7 @@
             rebuild();
             return;
         }
-        
+
         if (win.pageYOffset != scroll.top) {
             updateScrollPos();
             recalcAllPos();
@@ -274,7 +274,7 @@
             },
             nodeOffset = getElementOffset(node),
             parentOffset = getElementOffset(parentNode),
-            
+
             parent = {
                 node: parentNode,
                 css: {
@@ -371,8 +371,8 @@
         updateScrollPos();
         initAll();
 
-        win.addEventListener('scroll', onScroll);
-        win.addEventListener('wheel', onWheel);
+        win.addEventListener('scroll', onScroll, { passive: true });
+        win.addEventListener('wheel', onWheel, { passive: true });
 
         //watch for width changes
         win.addEventListener('resize', rebuild);
@@ -390,11 +390,11 @@
         if (!initialized) return;
 
         deinitAll();
-        
+
         for (var i = watchArray.length - 1; i >= 0; i--) {
             watchArray[i] = getElementParams(watchArray[i].node);
         }
-        
+
         initAll();
     }
 
@@ -412,7 +412,7 @@
 
     function stop() {
         pause();
-        deinitAll(); 
+        deinitAll();
     }
 
     function kill() {

diff --git a/dist/stickyfill.min.js b/dist/stickyfill.min.js
diff --git a/src/stickyfill.js b/src/stickyfill.js
@@ -67,7 +67,7 @@
             rebuild();
             return;
         }
-        
+
         if (win.pageYOffset != scroll.top) {
             updateScrollPos();
             recalcAllPos();
@@ -267,7 +267,7 @@
             },
             nodeOffset = getElementOffset(node),
             parentOffset = getElementOffset(parentNode),
-            
+
             parent = {
                 node: parentNode,
                 css: {
@@ -364,8 +364,8 @@
         updateScrollPos();
         initAll();
 
-        win.addEventListener('scroll', onScroll);
-        win.addEventListener('wheel', onWheel);
+        win.addEventListener('scroll', onScroll, { passive: true });
+        win.addEventListener('wheel', onWheel, { passive: true });
 
         //watch for width changes
         win.addEventListener('resize', rebuild);
@@ -383,11 +383,11 @@
         if (!initialized) return;
 
         deinitAll();
-        
+
         for (var i = watchArray.length - 1; i >= 0; i--) {
             watchArray[i] = getElementParams(watchArray[i].node);
         }
-        
+
         initAll();
     }
 
@@ -405,7 +405,7 @@
 
     function stop() {
         pause();
-        deinitAll(); 
+        deinitAll();
     }
 
     function kill() {