issue cucumber#637 - addressing a PR comment for tidying up code

10xtechie · Jun 30, 2022 · f9cf999 · f9cf999
1 parent f8aec78
commit f9cf999
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/themes/cucumber-sb/static/js/site.js b/themes/cucumber-sb/static/js/site.js
@@ -118,6 +118,14 @@ function getLangFromUrl(){
     return lang
 }
 
+function setDefaultLang(){
+  if(!supportedLanguages.includes(localStorage.getItem('language'))){
+    showOnly(defaulLanguage)
+    localStorage.setItem('language', defaulLanguage)
+  }else{
+    showOnly(localStorage.getItem('language'))
+  }
+}
 // Activate
 
 var supportedLanguages = [
@@ -133,22 +141,12 @@ var defaulLanguage = 'java'
 ready(function() {
   var selectedLang = getLangFromUrl();
   if((selectedLang == '' || selectedLang == null)){
-    if(localStorage.getItem('language') == ''){
-      showOnly(defaulLanguage)
-      localStorage.setItem('language', defaulLanguage)
-    }else{
-      showOnly(localStorage.getItem('language'))
-    }
+    setDefaultLang()
   }else{
     if(supportedLanguages.includes(selectedLang)){
       showOnly(selectedLang)
     }else{
-      if(localStorage.getItem('language') == ''){
-        showOnly(defaulLanguage)
-        localStorage.setItem('language', defaulLanguage)
-      }else{
-        showOnly(localStorage.getItem('language'))
-      }
+      setDefaultLang()
     }
   }