Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not familiar enough with the design pattern used here to properly modify the code, so for demo purposes and testing I have created this PR for #47 which contains a hack to get the role_arn value from the wpsnaphots config file to where it needs to be to assume roles.
These changes, in my testing, allow for the original design to work using profiles while also supporting ENV vars and role_arns when present in the config file. What does not work is having credentials hardcoded in the wpsnapshots config file. Adding the ability to load this information from wpsnapshots config would provide backwards compatibility, however.
I tested the following scenarios:
I did not test this on an ec2 instance with an IAM role assigned but presumably it would work.