Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete meta functionality #419

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Delete meta functionality #419

wants to merge 3 commits into from

Conversation

avag-novembit
Copy link
Contributor

In the SubscriptionsController::receive_item(..) method added logic to check for deleted meta data and, if found, delete it from website. closes #284

@avag-novembit avag-novembit mentioned this pull request Jun 28, 2019
Open
@jeffpaul jeffpaul added type:bug Something isn't working. meta labels Dec 18, 2019
@jeffpaul jeffpaul added this to the 2.0.0 milestone Dec 18, 2019
@jeffpaul jeffpaul requested a review from dkotter January 27, 2020 21:48
@jeffpaul
Copy link
Member

I'm moving this to the Future Release milestone to be considered alongside a broad approach to how we handle meta removal/deletion from remote sites. Apologies for the delay on response to this one @arsendovlatyan, but I want to be cautious with how we handle meta deletion.

@jeffpaul jeffpaul modified the milestones: 2.0.0, Future Release Mar 26, 2020
@jeffpaul jeffpaul added the needs:discussion This requires discussion to determine next steps. label Mar 26, 2020
@vikrampm1 vikrampm1 removed the meta label Dec 17, 2021
@jeffpaul jeffpaul modified the milestones: Future Release, 2.1.0 May 6, 2022
@jeffpaul jeffpaul removed the request for review from dkotter January 16, 2023 18:04
@jeffpaul
Copy link
Member

Unassigning reviewers here while we focus on the v2 refactoring and can then reassess how best to handle the root issue here.

@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

@avag-novembit thanks for the PR! Could you please rebase your PR on top of the latest changes in the base branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avag-novembit avag-novembit

Labels
needs:discussion This requires discussion to determine next steps. needs:refresh This requires a refreshed PR to resolve. type:bug Something isn't working.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Post meta is never actually deleted on the receiving end
3 participants
@avag-novembit @jeffpaul @vikrampm1