Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix php warning. #331

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Fix php warning. #331

merged 3 commits into from
Mar 6, 2019

Conversation

madmax3365
Copy link
Contributor

Closes: #330

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 19, 2019
@jeffpaul jeffpaul added this to the 1.4 milestone Feb 19, 2019
@jeffpaul
Copy link
Member

@madmax3365 thanks again for this PR.

@dkotter would you please give this a review as part of your items slated for the 1.4.0 release?

@helen
Copy link
Contributor

helen commented Mar 6, 2019

Just making a note here that I want to be sure we account for this later when we tackle #284, since this now makes the lack of meta deletion also an issue outside of set_meta() itself.

@helen helen merged commit 1ac45d0 into 10up:develop Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@madmax3365 madmax3365

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@madmax3365 @jeffpaul @helen @dkotter @arsendovlatyan