Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Classification] Ensure that the classification feature suggests or sets terms for enabled taxonomies only. #805

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

iamdharmesh
Copy link
Member

Description of the Change

While testing PR #804, I noticed that the plugin suggests (for manual mode) or sets (for automatic classification mode) terms for posts on all taxonomies for OpenAI Embeddings and Azure OpenAI Embeddings providers, terms should be suggested/set only for enabled taxonomies.

This PR fixes this issue by suggesting or setting terms for enabled taxonomies only.

How to Test the Change

  1. Checkout to the trunk branch.
  2. Set the classification feature using OpenAI Embeddings or Azure OpenAI Embeddings.
  3. Disable Classification for the Post Tag Taxonomy.
  4. Create a post, add some content, and click on the "Suggest terms & tags" button (for Manual mode) or save the post (for Automatic mode).
  5. Notice that terms are suggested or set for all taxonomies (categories and tags) even if tags are disabled.
  6. Checkout to this PR branch.
  7. Create a post, add some content, and click on the "Suggest terms & tags" button (for Manual mode) or save the post (for Automatic mode).
  8. Notice that terms are suggested or set for only the enabled taxonomies.

Changelog Entry

Fixed - Ensure that the classification feature suggests or sets terms for enabled taxonomies only.

Credits

Props @iamdharmesh

Checklist:

@iamdharmesh iamdharmesh self-assigned this Sep 26, 2024
@github-actions github-actions bot added this to the 3.2.0 milestone Sep 26, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 26, 2024
@jeffpaul jeffpaul requested review from a team and removed request for a team and jeffpaul September 26, 2024 13:15
@dkotter dkotter merged commit ac2c778 into develop Sep 26, 2024
14 checks passed
@dkotter dkotter deleted the fix/classification-enabled-taxonomies branch September 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants