-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Polly as a provider for the text-to-speech feature. #734
Conversation
I guess my first question would be do we need to use the SDK here? I know that can help simplify things but we haven't used any SDKs for the other Providers up to this point. I'm not opposed to it, just wondering if there was a specific reason. But I can think of two approaches we can take to mock the requests:
|
The main reason for using the SDK was to keep things simple, especially concerning signing and authenticating REST requests. I believe we don't have this complex authentication process with existing providers. I'm open to getting rid of the SDK here and writing a custom class for handling authentication and REST operations (similar to what we did for the OpenAPI). Please let me know if you think we should remove the SDK here.
Approach #1 seems like the better choice to me as it allows us to cover all scenarios. Thanks |
I think we're fine to proceed with keeping the SDK here. It does increase the size of the final release zip due to all the code the SDK brings but that should be fine.
That works for me |
Description of the Change
PR Adds Amazon Polly as a provider for the Text-to-speech feature.
Closes #728
@jeffpaul @dkotter Amazon Polly provides additional options such as Newscaster Speaking Style and SSML, which offers features like including breathing sounds and emphasizing specific words or phrases. I haven't implemented it in this PR, but we can consider integrating it in the future if there are specific client requirements around these features.
@dkotter, I haven't added E2E tests for this because I haven't figured out yet how to mock the API, given that we are using the AWS PHP SDK here. Please let me know if you have any ideas on this.
How to test the Change
Changelog Entry
Credits
Props @jeffpaul @iamdharmesh
Checklist: