-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#538 - Add setting to toggle the default behaviour of audio generation on a post. #539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
requested changes
Jul 18, 2023
dkotter
reviewed
Jul 18, 2023
Update description for default audio generation toggle setting. Co-authored-by: Darin Kotter <[email protected]>
…rivate to public for all providers.
…t_no_computer_vision_option_set test.
@joshuaabenazer Now that #549 has been merged, do you still want to proceed on this one? I know we discussed we may or may not want this one once the larger refactoring was done. If this is still valid, there are some merge conflicts that need cleaned up now. |
@joshuaabenazer Sounds good. I'm going to close this one out but feel free to re-open in the future if desired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Provides an extra setting for TTS to change the default behaviour of the the toggle to generate audio on posts.
Closes #538
How to test the Change
Changelog Entry
Credits
Props @joshuaabenazer
Checklist: