Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#538 - Add setting to toggle the default behaviour of audio generation on a post. #539

Closed

Conversation

joshuaabenazer
Copy link
Contributor

Description of the Change

Provides an extra setting for TTS to change the default behaviour of the the toggle to generate audio on posts.

Closes #538

How to test the Change

  1. Go to Tools -> ClassifAI -> Language Processing -> Microsoft Azure
  2. A new setting "Enabled by default" should be present and should be checked by default.
    1. Review that the "Enable audio generation" sidebar Gutenberg setting on new post or posts that do not have audio generated is enabled.
    2. Review to make sure this update to the code does not change the way new posts behave in terms of audio generation and adheres to how it was before the code change.
  3. Now uncheck the setting from point#2
    1. Review that the "Enable audio generation" sidebar Gutenberg setting on new post or posts that do not have audio generated is disabled.
    2. Review to make sure this toggle is adhered to and upon update the toggle the audio is generated if it does not exists.
    3. Review to make sure if the audio is available for a post and this toggle is then disabled it does not show up on the frontend.

Changelog Entry

Added - Setting to toggle the default behaviour of audio generation on a post.

Credits

Props @joshuaabenazer

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@joshuaabenazer joshuaabenazer requested a review from a team as a code owner July 17, 2023 18:37
@joshuaabenazer joshuaabenazer self-assigned this Jul 17, 2023
joshuaabenazer and others added 3 commits July 19, 2023 09:28
Update description for default audio generation toggle setting.

Co-authored-by: Darin Kotter <[email protected]>
@jeffpaul jeffpaul requested a review from dkotter July 31, 2023 16:52
@jeffpaul jeffpaul added this to the 2.3.0 milestone Jul 31, 2023
@dkotter
Copy link
Collaborator

dkotter commented Aug 4, 2023

@joshuaabenazer Now that #549 has been merged, do you still want to proceed on this one? I know we discussed we may or may not want this one once the larger refactoring was done. If this is still valid, there are some merge conflicts that need cleaned up now.

@joshuaabenazer
Copy link
Contributor Author

@dkotter @jeffpaul with the other PR this does get satisfied code-wise, and I feel since we have two different states of toggle for audio generation this would be incomplete without providing an option for the other state too. I would vote for skipping this for now.

@jeffpaul jeffpaul modified the milestones: 2.3.0, 2.4.0 Aug 8, 2023
@dkotter
Copy link
Collaborator

dkotter commented Aug 8, 2023

@joshuaabenazer Sounds good. I'm going to close this one out but feel free to re-open in the future if desired

@dkotter dkotter closed this Aug 8, 2023
@dkotter dkotter removed this from the 2.4.0 milestone Aug 8, 2023
@dkotter dkotter deleted the feature/538-enable-tts-default-setting branch October 26, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text To Speech: Provide option to set default setting of audio generation on new posts
3 participants