-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Generate Excerpt for the Classic Editor. #491
Merged
dkotter
merged 19 commits into
develop
from
feature/417-add-excerpt-generation-to-classic-editor
Aug 17, 2023
Merged
Added Generate Excerpt for the Classic Editor. #491
dkotter
merged 19 commits into
develop
from
feature/417-add-excerpt-generation-to-classic-editor
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
suggested changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesmorrison, Can you resolve code conflicts?
ravinderk
changed the title
Draft: Added Generate Excerpt for the Classic Editor.
Added Generate Excerpt for the Classic Editor.
Aug 10, 2023
@dkotter This pull request is ready for review. |
… Remove code that is no longer needed. Ensure we only load the features if enabled and if the post type supports it
dkotter
previously approved these changes
Aug 17, 2023
dkotter
approved these changes
Aug 17, 2023
dkotter
deleted the
feature/417-add-excerpt-generation-to-classic-editor
branch
August 17, 2023 21:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds the Excerpt Generation (introduced in #405 for Gutenberg) to the classic editor.
Closes #417
How to test the Change
textarea
; button text is updated (to Re-generate excerpt); button should be enabled.Changelog Entry
Credits
Props @jamesmorrison, @ravinderk, @dkotter
Checklist: