Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Generate Excerpt for the Classic Editor. #491

Merged
merged 19 commits into from
Aug 17, 2023

Conversation

jamesmorrison
Copy link
Member

@jamesmorrison jamesmorrison commented Jun 15, 2023

Description of the Change

Adds the Excerpt Generation (introduced in #405 for Gutenberg) to the classic editor.

Closes #417

How to test the Change

  1. Create a post using the classic editor
  2. Add some content and save as a draft (note: a draft must be saved as we need a post ID to make the OpenAI request)
  3. Locate the excerpt box and click "Generate excerpt"
  4. Button should be disabled; content should be added to the excerpt textarea; button text is updated (to Re-generate excerpt); button should be enabled.

Changelog Entry

Added - Excerpt Generation support in the classic editor.

Credits

Props @jamesmorrison, @ravinderk, @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jamesmorrison jamesmorrison requested review from a team, dkotter and jeffpaul as code owners June 15, 2023 17:12
@jeffpaul jeffpaul removed their request for review June 15, 2023 17:42
@jeffpaul jeffpaul added this to the 2.2.2 milestone Jun 15, 2023
@dkotter dkotter modified the milestones: 2.2.2, 2.2.3 Jun 27, 2023
@dkotter dkotter modified the milestones: 2.2.3, 2.3.0 Jul 6, 2023
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmorrison, Can you resolve code conflicts?

@ravinderk ravinderk self-assigned this Aug 8, 2023
@ravinderk ravinderk changed the title Draft: Added Generate Excerpt for the Classic Editor. Added Generate Excerpt for the Classic Editor. Aug 10, 2023
@ravinderk
Copy link
Contributor

@dkotter This pull request is ready for review.

dkotter
dkotter previously approved these changes Aug 17, 2023
@dkotter dkotter merged commit bd9ea48 into develop Aug 17, 2023
12 checks passed
@dkotter dkotter deleted the feature/417-add-excerpt-generation-to-classic-editor branch August 17, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add excerpt generation to the classic editor
4 participants