Correct a type declaration in the usePrimaryTerm component
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbillion
changed the title
usePrimaryTerm component
fabiankaegy
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@johnbillion Thanks so much for your fix! :)
Totally makes sense. Don't know how that slipped past me 👍
|
Maybe adding a test would prevent future slips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I noticed that the declared type for this entity record is incorrect. This returns a term object, not a taxonomy object.
How to test the Change
Not sure, I only noticed this while taking a look through the component file.
Changelog Entry
Credits
Props @johnbillion
Checklist: