-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Syndication Links support #331
base: develop
Are you sure you want to change the base?
Conversation
@Firestorm980 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Firestorm980,
Thanks a lot for working on this and raising the PR. Great work here. PR looks good but I have noticed one issue during testing: when we publish the post and it gets autoposted on X/Twitter, I didn't see syndication links added to the post (even after refreshing). Additionally, when I retweet, I find the syndication links filled up with the first input blank. Please check the attached video for more information on this.
Screen.Recording.2024-07-05.at.8.26.02.PM.mov
Could you please help check if this is happening on your end as well?
Thanks,
👋🏼 @dshanske would love your review here as well |
Will do |
It looks good to me. Makes me think I should just give in and write a block compatible version...but...maybe this will inspire someone to submit a PR or two. To be honest. the concept of the plugin is a nice and simple...store and display links philosophy. |
@jeffpaul I can replicate the same issue with the PR as mentioned by @iamdharmesh |
Description of the Change
Adds support for Syndication Links with autoshare. Automatically adds the links to Twitter/X to Syndication Links meta.
Closes #79
How to test the Change
Notes:
Changelog Entry
Credits
Props @Firestorm980
Checklist: