Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Syndication Links support #331

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Firestorm980
Copy link

@Firestorm980 Firestorm980 commented Jun 28, 2024

Description of the Change

Adds support for Syndication Links with autoshare. Automatically adds the links to Twitter/X to Syndication Links meta.

Closes #79

How to test the Change

  1. Start the included WP environment and login
  2. Setup the Autoshare for Twitter plugin as normal
  3. Make sure Syndication Links plugin is active
  4. Add a new post with data, publsih
  5. Share the post via the Autoshare plugin as normal in classic or block editor mode
  6. When clicking the autoshare button in the panel to share the tweet, the link for the tweet should be automatically added to the syndication links
  7. Reload the page, the link should still exist under the Syndication Links meta panel
  8. Repeat steps 4 - 6, click "update" to verify the tweet link in the Syndication Links persists

Notes:

  • I didn't test with multiple accounts but it should be supported since the addition will loop through all tweet URLs. This should be tested as well.
  • The addition shouldn't throw any errors when the Syndication Links plugin is not activated or available

Changelog Entry

Added - Support for adding Twitter/X to Syndication Links automatically
Added - Syndication Links plugin to the WP environment config

Credits

Props @Firestorm980

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Firestorm980 Firestorm980 added the type:enhancement New feature or request. label Jun 28, 2024
@github-actions github-actions bot added this to the 2.2.1 milestone Jun 28, 2024
@Firestorm980 Firestorm980 marked this pull request as ready for review July 1, 2024 18:58
Copy link
Contributor

github-actions bot commented Jul 1, 2024

@Firestorm980 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Jul 1, 2024
@jeffpaul jeffpaul requested review from iamdharmesh and removed request for dkotter and jeffpaul July 1, 2024 19:45
@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jul 3, 2024
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Firestorm980,

Thanks a lot for working on this and raising the PR. Great work here. PR looks good but I have noticed one issue during testing: when we publish the post and it gets autoposted on X/Twitter, I didn't see syndication links added to the post (even after refreshing). Additionally, when I retweet, I find the syndication links filled up with the first input blank. Please check the attached video for more information on this.

Screen.Recording.2024-07-05.at.8.26.02.PM.mov

Could you please help check if this is happening on your end as well?

Thanks,

@jeffpaul
Copy link
Member

jeffpaul commented Jul 8, 2024

👋🏼 @dshanske would love your review here as well

@dshanske
Copy link

dshanske commented Jul 8, 2024

Will do

@dshanske
Copy link

dshanske commented Jul 8, 2024

It looks good to me. Makes me think I should just give in and write a block compatible version...but...maybe this will inspire someone to submit a PR or two. To be honest. the concept of the plugin is a nice and simple...store and display links philosophy.

@Sidsector9 Sidsector9 modified the milestones: 2.2.1, 2.3.0 Jul 9, 2024
@mehul0810
Copy link

@jeffpaul I can replicate the same issue with the PR as mentioned by @iamdharmesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review. type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IndieWeb syndication links + backfeed
6 participants