-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PostCSS Preset Env #331
Conversation
🦋 Changeset detectedLatest commit: 1db80d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # package-lock.json # packages/babel-preset-default/__tests__/__snapshots__/index.js.snap # packages/eslint-config/package.json # packages/toolkit/package.json
@nicholasio I'm unsure what's going on here, failing on a test within /projects/library. I think this is due to NPM doing funky things with installation since nothing has changed there |
@Antonio-Laguna fixed, anything else that needs to be done here? |
packages/toolkit/UPGRADING.md
Outdated
There are a few major changes in this release. While it probably won't break your build, it's worth noting everything that's changed. | ||
|
||
* Node version required of 18 (previous LTS) | ||
* Swapping `postcss-editor-styles` with `postcss-editor-styles-wrapper` which is compatible with PostCSS 8. This should be a seamless change as this is a fork of the original package that was updated to be compatible with PostCSS 8 and fixes wrong behaviour in some circumstances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change for those extending the postcss.config.js file so they will need to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
@Antonio-Laguna updated a few things, was there anything else here before we merge this? |
@nicholasio no, all good here! Thanks for giving it a final push. I was feeling stuck with this! |
Related Issue/RFC: #326
Closes #326 #321
Description of the Change
Upgrade PostCSS to V9. I've also updated some dependencies to avoid security issues. I was getting
5 high severity vulnerabilities
and now it's down tofound 0 vulnerabilities
. I think this also fixes the prettier issue for good.Checklist: