Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stop using react fast refresh fork #328

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Sep 25, 2023

Related Issue/RFC: #323

Description of the Change

We do not need to use our react fast refresh webpack plugin fork since the changes we needed were merged in the upstream package.

Alternate Designs

Possible Drawbacks

Verification Process

  • npm run dev
  • Edit a post and add the block "Example (with Linaria)"
  • Make changes to this block code and confirm the changes are hot reloaded in gutenberg.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: 2176224

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicholasio nicholasio merged commit 5a8f979 into develop Oct 4, 2023
5 checks passed
@nicholasio nicholasio deleted the feature/stop-using-react-fast-refresh-fork branch October 4, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants