Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix overflow bugs in VDJ FR3 start identification. #316

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

macklin-10x
Copy link
Contributor

@macklin-10x macklin-10x commented Jan 18, 2024

Consistently handle FR3 start window bounds in the face of sequences that are possibly shorter than the window we're searching in. Bail out early if the full search window does not overlap with the sequence, to ensure that the FR3 start computed based on a given contig is the same irrespective of the amount of prefix clipped in the contig.

vdj_ann/src/vdj_features.rs Outdated Show resolved Hide resolved
@macklin-10x
Copy link
Contributor Author

@sreenathkrishnan I'd appreciate a second look at this.

@macklin-10x macklin-10x merged commit 6856c58 into 10XGenomics:master Jan 23, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants