Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Replace is_valid with refactored version #1003

Replace is_valid with refactored version

Replace is_valid with refactored version #1003

Triggered via pull request February 9, 2024 18:15
Status Failure
Total duration 4m 20s
Artifacts

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 11 warnings
this function takes 12 arguments but 13 arguments were supplied: vdj_ann/src/annotate.rs#L3344
error[E0061]: this function takes 12 arguments but 13 arguments were supplied --> vdj_ann/src/annotate.rs:3344:26 | 3344 | let annotation = ContigAnnotation::from_seq( | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 3357 | None, | ---- argument of type `std::option::Option<_>` unexpected | note: associated function defined here --> vdj_ann/src/annotate.rs:3168:12 | 3168 | pub fn from_seq( | ^^^^^^^^ 3169 | b: &DnaString, // the contig | ------------- 3170 | q: &[u8], // qual scores for the contig | -------- 3171 | tigname: &str, // name of the contig | ------------- 3172 | refdata: &RefData, // reference data | ----------------- 3173 | nreads: usize, // number of reads assigned to contig | ------------- 3174 | numis: usize, // number of umis assigned to contig | ------------ 3175 | high_confidence: bool, // declared high confidence? | --------------------- 3176 | validated_umis: Option<Vec<String>>, // validated UMIs | ----------------------------------- 3177 | non_validated_umis: Option<Vec<String>>, // non-validated UMIs | --------------------------------------- 3178 | invalidated_umis: Option<Vec<String>>, // invalidated UMIs | ------------------------------------- 3179 | is_cell: bool, // was the barcode declared a cell? | ------------- 3180 | jsupp: Option<JunctionSupport>, // num reads, umis supporting junction | ------------------------------ help: remove the extra argument | 3344 | let annotation = ContigAnnotation::from_seq(&contig_seq, &contig_qual, "clonotype125_consensus_1", &refdata, 120, 2, true, None, None, None, false, None); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
rust
Clippy had exited with the 101 exit code
rust
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, 10XGenomics/clippy-check@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
calling `set_len()` immediately after reserving a buffer creates uninitialized values: vector_utils/src/lib.rs#L490
warning: calling `set_len()` immediately after reserving a buffer creates uninitialized values --> vector_utils/src/lib.rs:490:5 | 490 | x.reserve(n); | ^^^^^^^^^^^^^ 491 | x.set_len(n); /* unsafe */ | ^^^^^^^^^^^^ | = help: initialize the buffer or wrap the content in `MaybeUninit` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninit_vec note: the lint level is defined here --> vector_utils/src/lib.rs:487:8 | 487 | #[warn(clippy::uninit_vec)] | ^^^^^^^^^^^^^^^^^^
this function has too many arguments (9/7): pretty_trace/src/lib.rs#L764
warning: this function has too many arguments (9/7) --> pretty_trace/src/lib.rs:764:1 | 764 | / fn force_pretty_trace_fancy( 765 | | log_file_name: String, 766 | | fd: i32, 767 | | exit_message: Option<String>, ... | 773 | | function_to_run: Option<fn(&str) -> ()>, 774 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
this function has too many arguments (8/7): vdj_ann/src/annotate.rs#L231
warning: this function has too many arguments (8/7) --> vdj_ann/src/annotate.rs:231:1 | 231 | / pub fn annotate_seq_core( 232 | | b: &DnaString, 233 | | refdata: &RefData, 234 | | ann: &mut Vec<(i32, i32, i32, i32, i32)>, ... | 239 | | verbose: bool, 240 | | ) { | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1599
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1599:54 | 1599 | let c1 = m1 == m2 && !have_utr_align2 && err1_nu == err2_nu && outside1 > outside2; | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err1_nu - err2_nu).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp = note: requested on the command line with `-W clippy::float-cmp`
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1600
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1600:54 | 1600 | let c2 = m2 == m1 && !have_utr_align1 && err2_nu == err1_nu && outside2 > outside1; | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err2_nu - err1_nu).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1609
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1609:37 | 1609 | || (m1 == m2 && err1 == err2 && outside1 > outside2) | ^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err1 - err2).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1610
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1610:37 | 1610 | || (m1 == m2 && err1 == err2 && outside1 == outside2 && t1 < t2) | ^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err1 - err2).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1610
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1610:53 | 1610 | || (m1 == m2 && err1 == err2 && outside1 == outside2 && t1 < t2) | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(outside1 - outside2).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1626
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1626:37 | 1626 | || (m2 == m1 && err2 == err1 && outside2 > outside1) | ^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err2 - err1).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
strict comparison of `f32` or `f64`: vdj_ann/src/annotate.rs#L1627
warning: strict comparison of `f32` or `f64` --> vdj_ann/src/annotate.rs:1627:37 | 1627 | || (m2 == m1 && err2 == err1 && outside2 == outside1 && t2 < t1) | ^^^^^^^^^^^^ help: consider comparing them within some margin of error: `(err2 - err1).abs() < error_margin` | = note: `f32::EPSILON` and `f64::EPSILON` are available for the `error_margin` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp